|
Size: 91
Comment:
|
Size: 956
Comment: Fix name and remove Rietveld instructions.
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 3: | Line 3: |
| = Code reviews with Rietveld = | = Code reviews with Github = |
| Line 5: | Line 5: |
| '''TODO''' | You can prepare a code review by making a pull-request in your own Fast Downward fork on Github. * Prepare your issue or feature branch (e.g. issue123) according to [[../Git|our Git workflow]]. * Push your Fast Downward repository to Github and navigate to it in your browser. * Click "Pull requests" and click "New pull request", then select the `main` branch of '''your repository''' on the left and the `issue123` branch on the right. * Click "Create pull request". * Link to the pull request from the issue tracker. == Compare arbitrary revisions == Compare any two revisions by following the steps above but using the commit IDs of the commits you want to compare instead of the branch names. It is not possible to create a pull request this way because merging might not make sense for the selected commits but you'll be able to see the code difference. |
Back to developer page.
Code reviews with Github
You can prepare a code review by making a pull-request in your own Fast Downward fork on Github.
Prepare your issue or feature branch (e.g. issue123) according to our Git workflow.
- Push your Fast Downward repository to Github and navigate to it in your browser.
Click "Pull requests" and click "New pull request", then select the main branch of your repository on the left and the issue123 branch on the right.
- Click "Create pull request".
- Link to the pull request from the issue tracker.
Compare arbitrary revisions
Compare any two revisions by following the steps above but using the commit IDs of the commits you want to compare instead of the branch names. It is not possible to create a pull request this way because merging might not make sense for the selected commits but you'll be able to see the code difference.